[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

Freddy, Ye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 26 04:42:30 PDT 2023


FreddyYe marked 3 inline comments as done.
FreddyYe added inline comments.


================
Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37
+; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
+; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake_s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
+; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=lunarlake 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
----------------
RKSimon wrote:
> FreddyYe wrote:
> > RKSimon wrote:
> > > duplicate?
> > No, it is `-` vs `_`
> Got it - does that mean we should have added "graniterapids_d" as well?
Right! I realized that's a missing when I added here. But it may introduce conflict here so I prefer to add it in later patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156239/new/

https://reviews.llvm.org/D156239



More information about the cfe-commits mailing list