[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

Younan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 26 01:14:38 PDT 2023


zyounan created this revision.
zyounan added a reviewer: nridge.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
zyounan requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

This is a follow-up to D151785 <https://reviews.llvm.org/D151785>, addressing https://github.com/clangd/clangd/issues/1703.

The previous approach of peeling pointer types during a traversal
using getPointeeType might have produced unexpected results; since
the method would implicitly desugar the type if the type being passed
in could not be cast to a Pointer-like Type.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156300

Files:
  clang-tools-extra/clangd/InlayHints.cpp
  clang-tools-extra/clangd/unittests/InlayHintTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156300.544251.patch
Type: text/x-patch
Size: 6923 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230726/4e0fb438/attachment-0001.bin>


More information about the cfe-commits mailing list