[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 17:01:51 PDT 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
   // Additional dependency checks.
-  // TODO: The 'q' extension requires rv64.
-  // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
+  // The 'q' extension requires rv64.
+  if (XLen != 64 && Exts.count("q"))
----------------
I'm not sure this is true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156214/new/

https://reviews.llvm.org/D156214



More information about the cfe-commits mailing list