[PATCH] D154007: Reland "Try to implement lambdas with inalloca parameters by forwarding without use of inallocas."
    Reid Kleckner via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Tue Jul 25 13:59:21 PDT 2023
    
    
  
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clang/lib/CodeGen/CGClass.cpp:3094
+  // reason the name doesn't look as expected then just tack __impl to the
+  // front.
+  StringRef CallOpName = CallOpFn->getName();
----------------
Please add a TODO comment, suggestion:
`// TODO: Use the name mangler to produce the right name instead of using string replacement.`
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154007/new/
https://reviews.llvm.org/D154007
    
    
More information about the cfe-commits
mailing list