[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

The idea of emitting annotations on declarations seems fine.  (LLVM itself doesn't consume annotations anyway; they're meant as an extension mechanism for third-party tools.)

I'm a bit concerned the way this is implemented will end up dropping annotations we would previously emit.  For example:

  void foo();
  void *xxx = (void*)foo;
  __attribute__((annotate("bar"))) void foo(){}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156172/new/

https://reviews.llvm.org/D156172