[PATCH] D151834: Include math-errno with fast-math

[Zahira Ammarguellat via Phabricator via cfe-commits]

zahiraam added inline comments.


================
Comment at: clang/include/clang/Basic/FPOptions.def:29
 OPTION(Float16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod)
 OPTION(BFloat16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod)
+OPTION(MathErrno, bool, 1, BFloat16ExcessPrecision)
----------------
aaron.ballman wrote:
> Shouldn't this one be `Float16ExcessPrecision`? (Are we missing test coverage that would have caught that?)
oops! the test would be for the BFloat16ExcessPrecision, right?


================
Comment at: clang/include/clang/Basic/LangOptions.h:857
     setAllowApproxFuncOverride(!Value);
+    setMathErrnoOverride(Value);
     if (Value)
----------------
aaron.ballman wrote:
> Everything else does `!Value`; is it intentional that you're using `Value` instead?
Yes. I want to set the value of math-errno to the value of the pragma in the source.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151834/new/

https://reviews.llvm.org/D151834