[PATCH] D145229: [analyzer] Improve the documentation of the alpha.security.taint.TaintPropagation checker

Daniel Krupp via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 10:42:22 PDT 2023


dkrupp added inline comments.


================
Comment at: clang/docs/analyzer/checkers.rst:2469-2472
+  // User csa_mark_sanitize function is for the analyzer only
+  #ifdef __clang_analyzer__
+    void csa_mark_sanitized(const void *);
+  #endif
----------------
steakhal wrote:
> I was thinking of this when I mentioned "function with empty body".
> Notice the `inline`, so that one could put this into a header file without violating ODR.
> 
> ---
> This way at the callsites, one wouldn't need to ifdef-clutter the code.
> I think this would lead to more maintainable code in the long run, with happier users.
Good Point! I will add this to the next patch to this checker. thanks. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145229/new/

https://reviews.llvm.org/D145229



More information about the cfe-commits mailing list