[PATCH] D156040: [AMDGPU] Add dynamic stack bit info to kernel-resource-usage Rpass output

[Matt Arsenault via Phabricator via cfe-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

lgtm with nits



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1298
+      CurrentProgramInfo.DynamicCallStack ? "True" : "False";
+  EmitResourceUsageRemark("UsesDynamicStack", "Uses Dynamic Stack",
+                          UsesDynamicStackStr);
----------------
Drop "Uses". Could also just inline the bool->string


================
Comment at: llvm/test/CodeGen/AMDGPU/resource-optimization-remarks.ll:189
+
+declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1 immarg)
+ 
----------------
No typed pointers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156040/new/

https://reviews.llvm.org/D156040