[PATCH] D156172: [clang][CodeGen] Emit annotations for function declarations.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 06:18:12 PDT 2023


aaron.ballman added reviewers: efriedma, rjmccall, erichkeane.
aaron.ballman added a comment.

Adding additional reviewers for more opinions.

The changes seem reasonable to me given that the annotation attribute is used to squirrel data from the frontend to the backend (including via plugin attributes) and so its usage is pretty general. But I'd like a second opinion given that this attribute has only passed data along for function definitions for a *long* time. I'm not certain if changing this will cause surprises for the backend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156172/new/

https://reviews.llvm.org/D156172



More information about the cfe-commits mailing list