[PATCH] D156161: [clang-tidy] Add --enable-module-headers-parsing option

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 05:30:21 PDT 2023


carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.

LGTM! Feel free to add the comment about the implications of using the flag in the docs.



================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:270
+for C++20 and above, empowering specific checks
+to detect macro definitions within modules.
+)"),
----------------
PiotrZSL wrote:
> carlosgalvezp wrote:
> > Should we document the implications/risks of enabling this, so people are informed? Also the fact that is experimental and subject to change.
> Something like "May cause performance & parsing issues, and therefore is considered experimental." ? I'ts fine with me.
Sounds good to me!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156161/new/

https://reviews.llvm.org/D156161



More information about the cfe-commits mailing list