[clang] d0b54bb - [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test
Corentin Jabot via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 25 04:58:36 PDT 2023
Author: Kai Stierand
Date: 2023-07-25T13:58:30+02:00
New Revision: d0b54bb50e5110a004b41fc06dadf3fee70834b7
URL: https://github.com/llvm/llvm-project/commit/d0b54bb50e5110a004b41fc06dadf3fee70834b7
DIFF: https://github.com/llvm/llvm-project/commit/d0b54bb50e5110a004b41fc06dadf3fee70834b7.diff
LOG: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test
Fixes:
/home/buildbots/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1526:11: warning: comparison of integer expressions of different signedness: ‘const unsigned int’ and ‘const int’ [-Wsign-compare]
/home/buildbots/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/third-party/unittest/googletest/include/gtest/gtest.h:1526:11: warning: comparison of integer expressions of different signedness: ‘const long unsigned int’ and ‘const int’ [-Wsign-compare]
Reviewed By: cor3ntin
Differential Revision: https://reviews.llvm.org/D156224
Added:
Modified:
clang/unittests/libclang/LibclangTest.cpp
Removed:
################################################################################
diff --git a/clang/unittests/libclang/LibclangTest.cpp b/clang/unittests/libclang/LibclangTest.cpp
index b1f653441d0efe..295706c9e6ff8b 100644
--- a/clang/unittests/libclang/LibclangTest.cpp
+++ b/clang/unittests/libclang/LibclangTest.cpp
@@ -1220,7 +1220,7 @@ static_assert(true, message);
const char *Args[] = {"-xc++", "-std=c++26"};
ClangTU = clang_parseTranslationUnit(Index, fileName.c_str(), Args,
std::size(Args), nullptr, 0, TUFlags);
- ASSERT_EQ(clang_getNumDiagnostics(ClangTU), 0);
+ ASSERT_EQ(clang_getNumDiagnostics(ClangTU), 0u);
std::optional<CXCursor> staticAssertCsr;
Traverse([&](CXCursor cursor, CXCursor parent) -> CXChildVisitResult {
if (cursor.kind == CXCursor_StaticAssert) {
@@ -1229,7 +1229,7 @@ static_assert(true, message);
return CXChildVisit_Continue;
});
ASSERT_TRUE(staticAssertCsr.has_value());
- size_t argCnt = 0;
+ int argCnt = 0;
Traverse(*staticAssertCsr, [&argCnt](CXCursor cursor, CXCursor parent) {
switch (argCnt) {
case 0:
More information about the cfe-commits
mailing list