[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

Wang Pengcheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 02:24:35 PDT 2023


wangpc added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948
-  // TODO: The 'q' extension requires rv64.
-  // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'.
 
----------------
I think the comment is outdated here. `E` can be combined with all other extensions according to spec:
> Unless otherwise stated, standard extensions compatible with RV32I and RV64I are also compatible with RV32E and RV64E, respectively.
And, please see also D70401 for more context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156214/new/

https://reviews.llvm.org/D156214



More information about the cfe-commits mailing list