[PATCH] D156205: wasm: link crt1 even in case of -shared

YAMAMOTO Takashi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 25 01:47:25 PDT 2023


yamt added a comment.

> Should -shared modules also link with crt1-reactor.o by default then? Or should we add crt1-shared.o and use the whenever -shared is passed. Should we also make -shared incompatible with -mexec-model? It seems like -mexec-model should only apply to the main module, and not to the shared library that it loads.

wasi reactor model is for libraries.
i feel it's natural to make it cover shared libraries as well.

but i agree it can be done as you described too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156205/new/

https://reviews.llvm.org/D156205



More information about the cfe-commits mailing list