[PATCH] D156178: [HLSL] add pow library function

Joshua Batista via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 24 17:28:05 PDT 2023


bob80905 added inline comments.


================
Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:10
+// CHECK: call half @llvm.pow.f16(
+// NO_HALF: define noundef float @"?test_pow_half@@YA$halff@$halff at 0@Z"(
+// NO_HALF: call float @llvm.pow.f32(
----------------
bogner wrote:
> Why check the function name in the no-half case but not the other check?
This is the pattern I've been using since starting on the upstreaming effort, so I've been copying this pattern. I don't see a reason why the function name shouldn't be included, so I'll add it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156178/new/

https://reviews.llvm.org/D156178



More information about the cfe-commits mailing list