[PATCH] D156185: [clang][ConstExprEmitter] handle ArrayToPointerDecay ImplicitCastExpr of StringLiterals

Mon Jul 24 16:27:56 PDT 2023

nickdesaulniers added a comment.

In D156185#4530117 <https://reviews.llvm.org/D156185#4530117>, @efriedma wrote:

> We can do a whole bunch of these, but at some point we hit diminishing returns... bailing out here isn't *that* expensive.  Do you have some idea how far you want to go with this?  Adding a couple obvious checks like this isn't a big deal, but I don't want to build up a complete parallel infrastructure for scalar expressions here.

My goal here is to land https://reviews.llvm.org/D76096. If I have to build a whole complete parallel infra to do so, I will.  It might even be nice to start converging or deleting some of the duplication.

Some of these seem like very low hanging fruit, IMO, and probably still do speed up constant evaluation.

My (mis?)interpretation of https://reviews.llvm.org/D76096#4523828 was "find places where `Evaluate()` from clang/lib/AST/ExprConstant.cpp is called instead of the fast path very recently committed in D151587 <https://reviews.llvm.org/D151587>.  I guess I lost focus on the "struct or array part."

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156185/new/

https://reviews.llvm.org/D156185