[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

In D153536#4521156 <https://reviews.llvm.org/D153536#4521156>, @hubert.reinterpretcast wrote:

> In D153536#4512897 <https://reviews.llvm.org/D153536#4512897>, @dblaikie wrote:
>
>> but at least at a first blush I can't reproduce the failures shown...
>
> @dblaikie, you //did// reproduce the issue with the members. Both entries have DW_AT_decl_line 2 and DW_AT_data_member_location 0 (the second entry should indicate DW_AT_decl_line 3 and DW_AT_data_member_location 4):
>
>>   0x0000002e:   DW_TAG_structure_type
>>                   DW_AT_calling_convention        (DW_CC_pass_by_value)
>>                   DW_AT_name      ("t1")
>>                   DW_AT_byte_size (0x08)
>>                   DW_AT_decl_file ("/usr/local/google/home/blaikie/dev/scratch/unused_member.cpp")
>>                   DW_AT_decl_line (1)
>>   
>>   0x00000034:     DW_TAG_member
>>                     DW_AT_name    ("_")
>>                     DW_AT_type    (0x00000047 "int")
>>                     DW_AT_decl_file       ("/usr/local/google/home/blaikie/dev/scratch/unused_member.cpp")
>>                     DW_AT_decl_line       (2)
>>                     DW_AT_data_member_location    (0x00)
>>   
>>   0x0000003d:     DW_TAG_member
>>                     DW_AT_name    ("_")
>>                     DW_AT_type    (0x00000047 "int")
>>                     DW_AT_decl_file       ("/usr/local/google/home/blaikie/dev/scratch/unused_member.cpp")
>>                     DW_AT_decl_line       (2)
>>                     DW_AT_data_member_location    (0x00)
>>   
>>   0x00000046:     NULL
>
> As for the block-scope case, I am still able to reproduce the issue (and also your result that does not exhibit the issue). The key seems to be having the `_`s on the same line.

Ah, fair enough - probably easy enough for you to look for some kind of map with inadequate key material in CGDebugInfo somewhere, I'd guess...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153536/new/

https://reviews.llvm.org/D153536