[PATCH] D156024: [clang-tidy] Add --experimental-disable-module-headers-parsing option

[Piotr Zegar via Phabricator via cfe-commits]

PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:202
 
+  bool canEnableModuleHeadersParsing() const {
+    return !DisableModuleHeadersParsing;
----------------
carlosgalvezp wrote:
> Add docs?
for function ? It's straight forward, but yes, I can add some one liner...


================
Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:266
 
+static cl::opt<bool>
+    DisableModuleHeadersParsing("experimental-disable-module-headers-parsing",
----------------
carlosgalvezp wrote:
> Add documentation
This is hidden option. allow-enabling-analyzer-alpha-checkers is also hidden and has no documentation. That I base on.
So 2 questions:
- should it be hidden ?
- if stay hidden, does it need documentation ? (I'm fine with adding some)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156024/new/

https://reviews.llvm.org/D156024