[PATCH] D155452: [Flang] Add support for fsave-optimization-record

[victorkingi via Phabricator via cfe-commits]

victorkingi added inline comments.


================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:166-171
+                   clang::driver::options::OPT_fno_stack_arrays, false))
     opts.StackArrays = 1;
-  }
+
   if (args.hasFlag(clang::driver::options::OPT_floop_versioning,
-                   clang::driver::options::OPT_fno_loop_versioning, false)) {
+                   clang::driver::options::OPT_fno_loop_versioning, false))
     opts.LoopVersioning = 1;
----------------
dropped braces on single line if statements


================
Comment at: flang/test/Driver/frontend-forwarding.f90:26
 
+! RUN: %flang -### %s 2>&1 \
+! RUN:     -foptimization-record-file=%t.opt.yaml \
----------------
awarzynski wrote:
> Is a dedicated driver invocation needed for this test?
since -fsave-optimization-record and foptimization-record-file both produce opt-record-file and opt-record-format flags, I couldn't find an easier way to test for both calls without having to use 2 separate flang-new invocations.

We could ignore the foptimization-record-file test and assume if fsave-optimization-record passes, then the former passes as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155452/new/

https://reviews.llvm.org/D155452