[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

PoYao Chang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 24 06:56:46 PDT 2023


rZhBoYao added a comment.

Thanks for the reminder. I am aware of that. Browsing through 762672a73a1e <https://github.com/llvm/llvm-project/commit/762672a73a1e> and a560ccf2af7a <https://github.com/llvm/llvm-project/commit/a560ccf2af7a>, I believe the indeterminately sequenced requirement is met, neither of which test the codegen so I might just put the example shown in the release note in dr25xx.cpp.

In D156057#4527821 <https://reviews.llvm.org/D156057#4527821>, @Endill wrote:

> In D156057#4527787 <https://reviews.llvm.org/D156057#4527787>, @rZhBoYao wrote:
>
>> BTW, I am not sure if CWG2571 <http://wg21.link/cwg2571> is implemented by @cor3ntin? If so, can we mark it as done on https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles the warning around it tho.
>
> As a reminder, we don't change `cxx_dr_status.html` directly. Instead, we add a special comment in `clang/test/CXX/drs/dr25xx.cpp` (for the case of CWG2571), which should be accompanied by test case(s) if possible. You can follow the pattern of existing tests. After that `clang/www/make_cxx_dr_status` script should be run to update the HTML.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156057/new/

https://reviews.llvm.org/D156057



More information about the cfe-commits mailing list