[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 24 05:50:32 PDT 2023


aaron.ballman added inline comments.


================
Comment at: clang/unittests/libclang/LibclangTest.cpp:1201
+  const char testSource[] = R"cpp(
+#include <string_view>
+static constexpr std::string_view message{"Hello World!"};
----------------
This is going to be testing whatever STL headers are installed on the developer's machine; instead of including the STL header, you should mock up the `std::string_view` class so we're always testing something consistently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156053/new/

https://reviews.llvm.org/D156053



More information about the cfe-commits mailing list