[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

Joseph Faulls via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 24 02:12:11 PDT 2023


Joe added a comment.

> Theoretically, I think this matching of multilibs could be done without the need for multilib.yaml, but it is indeed much easier considering the logic is already there.

Actually, I retract this statement. There would be no way of knowing what the default library is without something telling you, i.e. a yaml file.

@michaelplatings thank you for the speedy comment!

> Multilib flags must be valid command line options. So as `+a` is not a valid command line option, it should not be used as a multilib flag.
>
> That said, I'm very aware that it would be desirable to specify attributes independently of command line options, so I think there's room for the design to grow.

Matching on extension is the most important thing for riscv. The only other way to do it under the current vision of multilib flags, as far as I'm aware, are some nasty and repetitive regexes. Do you think we could allow the design to grow to allow attributes prefixed by `+` in addition to flags?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155294/new/

https://reviews.llvm.org/D155294



More information about the cfe-commits mailing list