[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

Freddy, Ye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 23 18:46:09 PDT 2023


FreddyYe added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:1082
                                                   FeaturePREFETCHI,
-                                                  FeatureSHA512,
                                                   FeatureAMXCOMPLEX];
   list<SubtargetFeature> GNRFeatures =
----------------
FreddyYe wrote:
> RKSimon wrote:
> > RKSimon wrote:
> > > If this was incorrect it needs to be removed in its own patch
> > Doesn't the FeatureAMXCOMPLEX need to be on GNRDAdditionalFeatures and removed from GNRAdditionalFeatures?
> Right. Fixed in https://github.com/llvm/llvm-project/commit/5533fc10219747d1b312f8057edfb10d4d0fcd77
Sorry for mess here. Addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155798/new/

https://reviews.llvm.org/D155798



More information about the cfe-commits mailing list