[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Vlad Serebrennikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 23 11:03:28 PDT 2023


Endill added a comment.

Thank you for working on this!



================
Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:3
 // RUN:            -Wunsequenced -Wno-c++17-extensions -Wno-c++14-extensions %s
-// RUN: %clang_cc1 -fsyntax-only -verify=cxx17 -std=c++17 -Wno-unused -Wno-uninitialized \
-// RUN:            -Wunsequenced -Wno-c++17-extensions -Wno-c++14-extensions %s
+// RUN: %clang_cc1 -fsyntax-only -verify=cxx17 -std=c++23 -Wno-unused -Wno-uninitialized \
+// RUN:            -Wunsequenced %s
----------------
Checking for `cxx17` prefix in C++23 mode is misleading. I suggest to rename is to `since-cxx17`, and have a new run line for C++23 mode, leaving check in C++17 mode intact.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156057/new/

https://reviews.llvm.org/D156057



More information about the cfe-commits mailing list