[PATCH] D156044: [clangd] Exclude builtin headers from system include extraction

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 22 23:46:08 PDT 2023


sammccall created this revision.
sammccall added reviewers: kadircet, madscientist.
Herald added a subscriber: arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

Most headers that we discover are likely to be fairly portable across at least
clang/gcc, which is why we get away with adding them to clangd's search path.

This is not the case for the compiler builtin headers, which are shipped with
the parser and rely on parser builtins/features. We're better off *not* using
the the scanned builtin headers, and hoping our own intrinsics provide the
interface the code is relying on.

Fixes https://github.com/clangd/clangd/issues/1695


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156044

Files:
  clang-tools-extra/clangd/SystemIncludeExtractor.cpp
  clang-tools-extra/clangd/test/system-include-extractor.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156044.543252.patch
Type: text/x-patch
Size: 7077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230723/3ab30156/attachment.bin>


More information about the cfe-commits mailing list