[PATCH] D155857: [clang] fix nonnull warnings during build

[Farid Zakaria via Phabricator via cfe-commits]

fzakaria added a comment.

Ugh you are right.
So weird --

This works:

  if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
    append("-Wno-nonnull" CMAKE_CXX_FLAGS)
  endif()

I read the CMake documentation and it looked like the variable I used should have worked.
https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html#variable:CMAKE_%3CLANG%3E_COMPILER_ID

/shrug

Should I change to the version above or use the deprecated older variable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155857/new/

https://reviews.llvm.org/D155857