[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Jul 22 09:05:59 PDT 2023
MaskRay updated this revision to Diff 543200.
MaskRay added a comment.
Herald added a subscriber: wenlei.
bump version
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155992/new/
https://reviews.llvm.org/D155992
Files:
clang-tools-extra/clangd/SourceCode.cpp
clang-tools-extra/clangd/index/Background.cpp
clang-tools-extra/clangd/index/Serialization.cpp
clang-tools-extra/clangd/test/index-serialization/Inputs/sample.idx
Index: clang-tools-extra/clangd/index/Serialization.cpp
===================================================================
--- clang-tools-extra/clangd/index/Serialization.cpp
+++ clang-tools-extra/clangd/index/Serialization.cpp
@@ -457,7 +457,7 @@
// The current versioning scheme is simple - non-current versions are rejected.
// If you make a breaking change, bump this version number to invalidate stored
// data. Later we may want to support some backward compatibility.
-constexpr static uint32_t Version = 18;
+constexpr static uint32_t Version = 19;
llvm::Expected<IndexFileIn> readRIFF(llvm::StringRef Data,
SymbolOrigin Origin) {
Index: clang-tools-extra/clangd/index/Background.cpp
===================================================================
--- clang-tools-extra/clangd/index/Background.cpp
+++ clang-tools-extra/clangd/index/Background.cpp
@@ -155,7 +155,7 @@
BackgroundQueue::Task BackgroundIndex::indexFileTask(std::string Path) {
std::string Tag = filenameWithoutExtension(Path).str();
- uint64_t Key = llvm::xxHash64(Path);
+ uint64_t Key = llvm::xxh3_64bits(Path);
BackgroundQueue::Task T([this, Path(std::move(Path))] {
std::optional<WithContext> WithProvidedContext;
if (ContextProvider)
Index: clang-tools-extra/clangd/SourceCode.cpp
===================================================================
--- clang-tools-extra/clangd/SourceCode.cpp
+++ clang-tools-extra/clangd/SourceCode.cpp
@@ -559,7 +559,7 @@
}
FileDigest digest(llvm::StringRef Content) {
- uint64_t Hash{llvm::xxHash64(Content)};
+ uint64_t Hash{llvm::xxh3_64bits(Content)};
FileDigest Result;
for (unsigned I = 0; I < Result.size(); ++I) {
Result[I] = uint8_t(Hash);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155992.543200.patch
Type: text/x-patch
Size: 1749 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230722/0765b22c/attachment.bin>
More information about the cfe-commits
mailing list