[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D154324#4522552 <https://reviews.llvm.org/D154324#4522552>, @Hahnfeld wrote:

> In D154324#4522551 <https://reviews.llvm.org/D154324#4522551>, @alexfh wrote:
>
>> BTW, if in a.h I change
>>
>>   typename std::enable_if<::p::P<T>::value>::type>
>>
>> to
>>
>>   typename std::enable_if<p::P<T>::value>::type>
>>
>> Compilation succeeds.
>
> For the fun of it, could you test https://reviews.llvm.org/D153003 on this reproducer and also the internal, real code?

Without this patch (D154324 <https://reviews.llvm.org/D154324>), D153003 <https://reviews.llvm.org/D153003> alone doesn't cause problems with the code that this patch broke. But that's not much information: thousands of Clang and LLVM commits didn't break that code either :)

Applying D153003 <https://reviews.llvm.org/D153003> on top of D154324 <https://reviews.llvm.org/D154324> fixes both the reduced and the original case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154324/new/

https://reviews.llvm.org/D154324