[PATCH] D156003: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

[Łukasz Anforowicz via Phabricator via cfe-commits]

lukasza created this revision.
Herald added a project: All.
lukasza requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Consider the test input below:

  struct [[clang::trivial_abi]] Trivial {
    Trivial() {}
    Trivial(Trivial&& other) {}
    Trivial& operator=(Trivial&& other) { return *this; }
    ~Trivial() {}
  };
  static_assert(__is_trivially_relocatable(Trivial), "");
  
  struct [[clang::trivial_abi]] S {
    S(S&& other) {}
    S& operator=(S&& other) { return *this; }
    ~S() {}
    union { Trivial field; };
  };
  static_assert(__is_trivially_relocatable(S), "");


Before the fix Clang would warn that 'trivial_abi' is disallowed on 'S'
because it has a field of a non-trivial class type (the type of the
anonymous union is non-trivial, because it doesn't have the
`[[clang::trivial_abi]]` attribute applied to it).  Consequently, before
the fix the `static_assert` about `__is_trivially_relocatable` would
fail.

Note that `[[clang::trivial_abi]]` cannot be applied to the anonymous
union, because Clang warns that 'trivial_abi' is disallowed on '(unnamed
union at ...)' because its copy constructors and move constructors are
all deleted. Also note that it is impossible to provide copy nor move
constructors for anonymous unions and structs.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D156003

Files:
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/test/SemaCXX/attr-trivial-abi.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156003.543100.patch
Type: text/x-patch
Size: 6689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230721/150ef804/attachment.bin>