[PATCH] D155396: [Sema][ObjC] Invalidate BlockDecl with invalid return expr & its parent BlockExpr

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 15:17:22 PDT 2023


rjmccall added a comment.

Dropping the entire block from the AST on error would be unfortunate for some kinds of tooling, but as long as we maintain it with a `RecoveryExpr`, that seems like a fine approach to me.

As a general rule, I think we should be tracking basically everything on the `BlockDecl` and let `BlockExpr` just have a reference to that on top of the baseline `Expr` storage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155396/new/

https://reviews.llvm.org/D155396



More information about the cfe-commits mailing list