[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules
Matthew Voss via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 21 14:41:59 PDT 2023
ormris added a comment.
This is a good way to resolve the inconsistencies I was looking at in my own review.
> I think whether a bitcode input file contains 2 modules (internal implementation strategy) should not be a criterion to require an additional driver option
Agreed. Most users don't know about the internal structure of bitcode modules, so I think it's best to use a consistent interface for all bitcode files.
================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:1174
+ else
+ M = std::move(*MOrErr);
+ }
----------------
Perhaps this variable name could be more descriptive. Maybe "FirstM" or something like that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154923/new/
https://reviews.llvm.org/D154923
More information about the cfe-commits
mailing list