[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 14:41:54 PDT 2023


hubert.reinterpretcast added a comment.

In D155544#4523857 <https://reviews.llvm.org/D155544#4523857>, @amyk wrote:

> Wouldn't this patch need to land before the back-end patch, because I introduce the option here, and then I use it in the backend patch?

Please move the `llvm/` changes into the back-end patch or land them separately first.

> In terms of checking for a 32-bit diagnostic within `check-aix-small-local-exec-tls-opt.ll`, the RUN lines in that test currently are 64-bit RUN lines. Perhaps in the backend patch, I should just add the 32-bit lines to show the diagnostic?

This seems to be the test designed to cover the non-codegen aspects of the attribute. In that light, the 32-bit run line belongs here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155544/new/

https://reviews.llvm.org/D155544



More information about the cfe-commits mailing list