[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 14:39:21 PDT 2023


probinson added inline comments.


================
Comment at: clang/lib/Headers/rdseedintrin.h:56
+/// ELSE
+///   Store16(__p, 0)
+///   result := 0
----------------
pengfei wrote:
> 32
Oops. Fixed.


================
Comment at: clang/lib/Headers/rdseedintrin.h:84
+/// ELSE
+///   Store16(__p, 0)
+///   result := 0
----------------
pengfei wrote:
> 64
Oops. Fixed.


================
Comment at: clang/lib/Headers/xsavecintrin.h:34
+/// ENDFOR
+/// __p.Header.XSTATE_BV := mask
+/// \endcode
----------------
pengfei wrote:
> It's not `mask` but `mask AND XINUSE[62:0]`. The bit[1] also relies on `MXCSR ≠ 1F80H`. I think we can simply use `__p.Header.XSTATE_BV[62:0] := INIT_FUNCTION(mask[62:0])`
Okay. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155859/new/

https://reviews.llvm.org/D155859



More information about the cfe-commits mailing list