[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

Mostly nits. One problem I have is the vector. I do not believe Flang will use the same for their "llvm.used" tracking. I think it makes more sense to provide a callback or just return the global and let the caller handle it.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1508
+  void
+  setPropertyExecutionMode(StringRef Name, bool isSPMDMode,
+                           std::vector<llvm::WeakTrackingVH> &LLVMCompilerUsed);
----------------



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4904
+void OpenMPIRBuilder::setPropertyExecutionMode(
+    StringRef Name, bool isSPMDMode,
+    std::vector<llvm::WeakTrackingVH> &LLVMCompilerUsed) {
----------------



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4917
+  LLVMCompilerUsed.emplace_back(GVMode);
+}
+
----------------
No `llvm::` here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155794/new/

https://reviews.llvm.org/D155794