[PATCH] D155982: Partially revert "clang/HIP: Remove __llvm_amdgcn_* wrapper hacks"
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 21 10:44:46 PDT 2023
arsenm added inline comments.
================
Comment at: clang/lib/Headers/__clang_hip_libdevice_declares.h:319
+// relevant.
+__device__ inline _Float16 __llvm_amdgcn_rcp_f16(_Float16 x) {
+ return ((_Float16)1.0f) / x;
----------------
yaxunl wrote:
> Can we add the deprecated attribute to urge people not to use them?
I initially added those, but thought it was a bit aggressive to put in always included headers. Is there an established practice for deprecating builtin header functions?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155982/new/
https://reviews.llvm.org/D155982
More information about the cfe-commits
mailing list