[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 07:33:44 PDT 2023


Hahnfeld added a comment.

In D154324#4522551 <https://reviews.llvm.org/D154324#4522551>, @alexfh wrote:

> BTW, if in a.h I change
>
>   typename std::enable_if<::p::P<T>::value>::type>
>
> to
>
>   typename std::enable_if<p::P<T>::value>::type>
>
> Compilation succeeds.

For the fun of it, could you test https://reviews.llvm.org/D153003 on this reproducer and also the internal, real code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154324/new/

https://reviews.llvm.org/D154324



More information about the cfe-commits mailing list