[PATCH] D155848: [clang][analyzer]Fix non-effective taint sanitation

Fri Jul 21 07:11:47 PDT 2023

dkrupp added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:970
-  ForEachCallArg(
-      [&](ArgIdxTy I, const Expr *E, SVal V) {
-        if (PropDstArgs.contains(I)) {
----------------
steakhal wrote:
> dkrupp wrote:
> > dkrupp wrote:
> > > steakhal wrote:
> > > > Is it only a formatting hunk?
> > > > I cannot really tell from my phone xd
> > > yeap. formatting only.
> > Yes. Only formatting.
> I would suggest not mixing formatting changes with semantic changes in a single revision. Consider not doing the formatting, or at least format in a different revision.
> 
> Adding and updating comments are fine.
Yes. I realized. I reverted the formatting change.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155848/new/

https://reviews.llvm.org/D155848