[PATCH] D155898: [clangd] Fix go-to-type target location

Utkarsh Saxena via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 03:58:10 PDT 2023


usaxena95 accepted this revision.
usaxena95 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:347
+void enhanceLocatedSymbolsFromIndex(
+    llvm::MutableArrayRef<LocatedSymbol> Result,
+    const llvm::DenseMap<SymbolID, size_t> &ResultIndex,
----------------
nit: ResultIndex looks like an implementation detail of this function and the callers do not need it. SymbolID is already present as LocatedSymbol::ID so we can compute this map in this function itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155898/new/

https://reviews.llvm.org/D155898



More information about the cfe-commits mailing list