[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

Jirui Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 21 02:08:11 PDT 2023


JiruiWu added inline comments.


================
Comment at: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c:100
   struct packed_struct on_callee_stack;
   on_callee_stack = va_arg(vl, struct packed_struct);
 }
----------------
chill wrote:
> Can we add some `CHECK:` lines here and to other variadic functions as well (I recognize it might not be straightforward)?
I compared the assembly output before and after applying my patch, there is no change in this part and thus I think there is no need for additional `CHECK:` lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146242/new/

https://reviews.llvm.org/D146242



More information about the cfe-commits mailing list