[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 21 00:37:25 PDT 2023
rsmith added a comment.
This looks correct to me, but it's still a little subtle. Perhaps it'd be clearer to map the method to an integer (0 for copy assignment, 1 for move assignment, 2 for destructor, 3 for equality comparison), and then order them by that integer? That'd be more obviously a strict weak order.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155809/new/
https://reviews.llvm.org/D155809
More information about the cfe-commits
mailing list