[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

Thu Jul 20 19:22:37 PDT 2023

pengfei added inline comments.

================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925
 // CHECK_GNR_M64: #define __AMX_BF16__ 1
-// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1
+// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1
+// CHECK_GNRD_M64: #define __AMX_COMPLEX__ 1
----------------
FreddyYe wrote:
> RKSimon wrote:
> > Won't this fail on the graniterapids-d run?
> Whops, I didn't realize this problem before! But it indeed doesn't fail. Need to figure out why...
I'm guessing when using multi prefixes, it will try to match with the second one if the first failed. It's common and easy to understand for positive check but a bit confusing for negative one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155798/new/

https://reviews.llvm.org/D155798