[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 18:43:54 PDT 2023


pengfei added inline comments.


================
Comment at: clang/lib/Headers/rdseedintrin.h:56
+/// ELSE
+///   Store16(__p, 0)
+///   result := 0
----------------
32


================
Comment at: clang/lib/Headers/rdseedintrin.h:84
+/// ELSE
+///   Store16(__p, 0)
+///   result := 0
----------------
64


================
Comment at: clang/lib/Headers/xsavecintrin.h:34
+/// ENDFOR
+/// __p.Header.XSTATE_BV := mask
+/// \endcode
----------------
It's not `mask` but `mask AND XINUSE[62:0]`. The bit[1] also relies on `MXCSR ≠ 1F80H`. I think we can simply use `__p.Header.XSTATE_BV[62:0] := INIT_FUNCTION(mask[62:0])`


================
Comment at: clang/lib/Headers/xsavecintrin.h:65
+/// ENDFOR
+/// __p.Header.XSTATE_BV := mask
+/// \endcode
----------------
ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155859/new/

https://reviews.llvm.org/D155859



More information about the cfe-commits mailing list