[PATCH] D154503: [Sema] Fix handling of functions that hide classes

Thu Jul 20 15:19:22 PDT 2023

shafik added inline comments.

================
Comment at: clang/lib/Sema/SemaLookup.cpp:507

+  // C++ [basic.scope.hiding]p2:
+  //   A class name or enumeration name can be hidden by the name of
----------------
john.brawn wrote:
> shafik wrote:
> > This section does not exist anymore, it was replaced in [p1787](https://wg21.link/p1787) which resolved a very large number of DRs and reflector discussions. I have not fully digested the paper myself but this change should reflect the new wording as it exists in the current draft. 
> It looks like https://eel.is/c++draft/basic.lookup#general-4 is the same thing but worded differently. That draft hasn't gone into a published standard though, and could change before it gets published, and the same section is referenced elsewhere in this file (and there are probably other references in this file to parts of the standard that will get changed in the next version), so I think it would make more sense to change all such comments at once when that change has gone into a published version of the standard.
This paper was voted in [11/2020](https://github.com/cplusplus/draft/issues/4326) and it considered [C++23](https://github.com/cplusplus/papers/issues/533) and so it is safe to rely on this wording. Any behavior that does not match this wording should be considered a bug.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154503/new/

https://reviews.llvm.org/D154503