[PATCH] D155885: [include-cleaner] Switch Include from FileEntry* -> FileEntryRef

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 14:12:16 PDT 2023


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman.
Herald added a reviewer: njames93.
Herald added a project: All.
sammccall requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Unlike Header, we really do have a preferred spelling for an include: the one
that we used to open the file.

The fact that Header is still FileEntry* makes it difficult to accidentally
use path equality when we want inode equality.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155885

Files:
  clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp
  clang-tools-extra/clangd/IncludeCleaner.cpp
  clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h
  clang-tools-extra/include-cleaner/lib/Analysis.cpp
  clang-tools-extra/include-cleaner/lib/Record.cpp
  clang-tools-extra/include-cleaner/lib/Types.cpp
  clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
  clang-tools-extra/include-cleaner/unittests/TypesTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155885.542668.patch
Type: text/x-patch
Size: 8291 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230720/219a9e93/attachment.bin>


More information about the cfe-commits mailing list