[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

Digger Lin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 14:05:49 PDT 2023


DiggerLin updated this revision to Diff 542660.
DiggerLin added a comment.

1. rebase the code
2. for the `env OBJECT_MODE=` or is `env OBJECT_MODE=""` , the `ranlib` and `ar` in AIX OS , have different behaviors(ranlib looks as -X32 , but `ar` and `nm` output error ),

I change `llvm-ranlib` as the same behavior as `ar` and `llvm-ar`, output an error(I think output error is more reasonable).  and look env OBJECT_MODE unset as default 32-BIT for `llvm-ranlib`  as AIX OS command `ranlib` , `nm` ,`ar`.

bash-5.0$ env OBJECT_MODE= ar  -q tmp.a bug.patch
ar: 0707-133 The OBJECT_MODE environment variable has an invalid setting.

  OBJECT_MODE must be 32, 64, 32_64, d64, or any.

bash-5.0$ env OBJECT_MODE="" ar  -q tmp.a bug.patch
ar: 0707-133 The OBJECT_MODE environment variable has an invalid setting.

  OBJECT_MODE must be 32, 64, 32_64, d64, or any.

bash-5.0$ env OBJECT_MODE="" ranlib  tmpk.a
bash-5.0$ env OBJECT_MODE= ranlib  tmpk.a


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142660/new/

https://reviews.llvm.org/D142660

Files:
  clang/test/lit.cfg.py
  llvm/include/llvm/Object/Archive.h
  llvm/include/llvm/Object/ArchiveWriter.h
  llvm/lib/Object/Archive.cpp
  llvm/lib/Object/ArchiveWriter.cpp
  llvm/test/lit.cfg.py
  llvm/test/tools/llvm-ranlib/aix-X-option.test
  llvm/tools/llvm-ar/llvm-ar.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142660.542660.patch
Type: text/x-patch
Size: 18758 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230720/819d0d29/attachment-0001.bin>


More information about the cfe-commits mailing list