[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

Gedare Bloom via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 20 13:18:08 PDT 2023


gedare added a comment.

In D155239#4520067 <https://reviews.llvm.org/D155239#4520067>, @HazardyKnusperkeks wrote:

> Everything is fine, I just need to know how the attribute stuff is formatted with plain LLVM style.

`__attribute__` is formatted with plain LLVM style in 5-10 other test cases.  For plain llvm style probably the best is `UnderstandsAttributes`. I did add the test cases at the start of `ConfigurableSpacesInParens` with plain llvm style to establish a baseline.

In reviewing those test cases I did see a good reason to add another test of attribute placement. I have now covered function decl attributes before and after the function name, and variable attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155239/new/

https://reviews.llvm.org/D155239



More information about the cfe-commits mailing list