[PATCH] D154324: [C++20] [Modules] [ODRHash] Use CanonicalType for base classes

Thu Jul 20 12:38:29 PDT 2023

alexfh added a comment.

In D154324#4516964 <https://reviews.llvm.org/D154324#4516964>, @alexfh wrote:

> In D154324#4516917 <https://reviews.llvm.org/D154324#4516917>, @ChuanqiXu wrote:
>
>> Maybe we got something wrong with this. I'd like to revert this patch in case it breaks something. But would you like to reduce your reproducer further to a state without external includes to STL or protobuf? Then we can add the reduced reproducer to the tests to avoid further regressions.
>
> That turned out to be quite time-consuming, but I can try nevertheless. I also asked @rsmith if he could figure out what the problem is. Hopefully, he can help with the test case, if gets to the bottom of the problem.

I have a reduced reproducer, but I still depends on the internal build setup. I need a bit more time to make the reproducer standalone.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154324/new/

https://reviews.llvm.org/D154324