[PATCH] D154368: [Clang] Fix constraint checking of non-generic lambdas.
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 20 12:21:45 PDT 2023
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some questions about comments in the test.
================
Comment at: clang/test/SemaTemplate/concepts.cpp:531
SingleDepthReferencesTopLambda(v);
// FIXME: This should error on constraint failure! (Lambda!)
SingleDepthReferencesTopLambda(will_fail);
----------------
Comment is now stale and can be removed?
================
Comment at: clang/test/SemaTemplate/concepts.cpp:580
ChecksLocalVar(v);
// FIXME: This should error on constraint failure! (Lambda!)
ChecksLocalVar(will_fail);
----------------
This one can also be removed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154368/new/
https://reviews.llvm.org/D154368
More information about the cfe-commits
mailing list