[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options
Michael Platings via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 20 05:36:00 PDT 2023
michaelplatings added inline comments.
================
Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49
+// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV
+// SME-SUBFEATURE-CONFLICT-REV: "-target-feature" "-sme-f64f64" "-target-feature" "+sme-i16i64" "-target-feature" "+sme" "-target-feature" "+bf16"
----------------
Hi Bryan, this test fails in our downstream toolchain because it has additional features that show up in between these features. Breaking the line up as shown would fix this. Another option could be to add `{{.*}}` between the features. Doing likewise for other checks in this file would make them less brittle as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142702/new/
https://reviews.llvm.org/D142702
More information about the cfe-commits
mailing list