[PATCH] D155814: Fix the linting problems which caused `clang/utils/ci/run-buildbot check-format` to return 1.
Amirreza Ashouri via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 20 04:23:14 PDT 2023
AMP999 created this revision.
AMP999 added a reviewer: clang.
AMP999 added a project: clang.
Herald added a reviewer: NoQ.
Herald added a project: All.
AMP999 requested review of this revision.
Herald added a subscriber: cfe-commits.
`clang/utils/ci/run-buildbot check-format` command in build process caused my last differential, https://reviews.llvm.org/D155714, to fail (https://buildkite.com/llvm-project/clang-ci/builds/355) and when I checked the logs and found out that the problem doesn't reside in my change. So I fixed the linting problem in the `clang/lib/Analysis/UnsafeBufferUsage.cpp` file which is to remove some redundant white spaces.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D155814
Files:
clang/lib/Analysis/UnsafeBufferUsage.cpp
Index: clang/lib/Analysis/UnsafeBufferUsage.cpp
===================================================================
--- clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1890,10 +1890,10 @@
const ParmVarDecl *Parm = FD->getParamDecl(i);
if (Parm->isImplicit())
- continue;
+ continue;
// FIXME: If a parameter has no name, it is unused in the
// definition. So we could just leave it as it is.
- if (!Parm->getIdentifier())
+ if (!Parm->getIdentifier())
// If a parameter of a function definition has no name:
return std::nullopt;
if (i == ParmIdx)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155814.542421.patch
Type: text/x-patch
Size: 668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230720/7f00d9d5/attachment.bin>
More information about the cfe-commits
mailing list