[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/test/AST/Interp/builtin-functions.cpp:153
+  static_assert(__builtin_LINE() == 152, "");
+}
----------------
cor3ntin wrote:
> tbaeder wrote:
> > tbaeder wrote:
> > > cor3ntin wrote:
> > > > what is missing to enable the existing source location tests with the new intterpreter?
> > > There is a crash that I need to investigate first, //but// `SemaCXX/source_location.cpp` also uses stuff like `static_assert(noexcept(...));` that I don't handle yet.
> > Okay, after my last two patches I uploaded, the only problem missing is the broken source locations for initializers.
> I think it might be worth doing in this patch (unless it requires a lot of work)
I was wrong and there's some other work needed. Namely, I need to redo how we do initializers. I will definitely tackel that this quarter and dial down the work on new features.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155627/new/

https://reviews.llvm.org/D155627